Skip to content

[Chrome] Grid Layout by default#243181

Merged
Dosant merged 1 commit intoelastic:mainfrom
Dosant:grid-layout-default
Nov 24, 2025
Merged

[Chrome] Grid Layout by default#243181
Dosant merged 1 commit intoelastic:mainfrom
Dosant:grid-layout-default

Conversation

@Dosant
Copy link
Contributor

@Dosant Dosant commented Nov 17, 2025

Summary

close #225263

This PR enables grid layout by default. This is supposed to be an internal change with minimal user-experience changes.
See for more info #225263

@Dosant Dosant mentioned this pull request Nov 17, 2025
Closed
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// ci:all-cypress-suites labels Nov 17, 2025
@Dosant Dosant marked this pull request as ready for review November 17, 2025 14:29
@Dosant Dosant requested review from a team as code owners November 17, 2025 14:29
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 17, 2025

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant mentioned this pull request Nov 17, 2025
Closed
55 tasks
@Dosant Dosant added the chrome-grid Work related to Chrome refactor to grid layout label Nov 17, 2025
@Dosant Dosant changed the title [Chrome Grid] Grid Layout by default [Chrome] Grid Layout by default Nov 17, 2025
afharo
afharo approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM.

janmonschke
janmonschke approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@Dosant Dosant requested a review from a team as a code owner November 20, 2025 16:05
Dosant
Dosant commented Nov 20, 2025
View reviewed changes
x-pack/solutions/observability/test/functional_solution_sidenav/tests/observability_sidenav.ts
}

// open Infrastructure popover and navigate to some link inside the panel
await solutionNavigation.sidenav.expandMore();
Copy link
Contributor Author

@Dosant Dosant Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a bit more space for the sidenav now, so the "infra" is not under "more" anymore in ftr tests

@Dosant Dosant force-pushed the grid-layout-default branch from 1c97a3f to 5017856 Compare November 21, 2025 10:21
@Dosant Dosant requested a review from a team as a code owner November 21, 2025 16:43
@Dosant Dosant requested review from parkiino and tomsonpl November 21, 2025 16:43
MiriamAparicio
MiriamAparicio approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@MiriamAparicio MiriamAparicio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomsonpl
tomsonpl approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@tomsonpl tomsonpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DW changes lgtm 👍

@Dosant Dosant force-pushed the grid-layout-default branch from 5a5774e to 3b15402 Compare November 24, 2025 13:22
@Dosant Dosant enabled auto-merge (squash) November 24, 2025 16:22
@Dosant Dosant merged commit edbe105 into elastic:main Nov 24, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 24, 2025

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 508.0KB 507.9KB -8.0B
kbnUiSharedDeps-srcJs 4.0MB 4.0MB +70.0B
total +62.0B

History

@Dosant Dosant mentioned this pull request Nov 28, 2025
Merged
Dosant added a commit that referenced this pull request Nov 28, 2025
@Dosant
[Chrome Grid] Revert the header displayed next to the sidenav (#244628)
4fc8027 
## Summary

One user-facing change we made with [the grid
layout](#243181) is that we
started displaying the Kibana header next to the sidenav instead of
above it.

**Before grid layout**

<img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32"
src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2"
/>

**With grid layout** 

<img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24"
src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6"
/>


----- 

With this PR, we revert this user-facing change and return the header to
the top of the nav.


<img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38"
src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636"
/>
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Dec 1, 2025
@Dosant @tkajtoch
[Chrome Grid] Revert the header displayed next to the sidenav (elasti…
3320150 
…c#244628)

## Summary

One user-facing change we made with [the grid
layout](elastic#243181) is that we
started displaying the Kibana header next to the sidenav instead of
above it.

**Before grid layout**

<img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32"
src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2"
/>

**With grid layout** 

<img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24"
src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6"
/>


----- 

With this PR, we revert this user-facing change and return the header to
the top of the nav.


<img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38"
src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636"
/>
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Dec 1, 2025
@Dosant @tsullivan
[Chrome Grid] Revert the header displayed next to the sidenav (elasti…
bebe613 
…c#244628)

One user-facing change we made with [the grid
layout](elastic#243181) is that we
started displaying the Kibana header next to the sidenav instead of
above it.

**Before grid layout**

<img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32"
src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2"
/>

**With grid layout**

<img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24"
src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6"
/>

-----

With this PR, we revert this user-facing change and return the header to
the top of the nav.

<img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38"
src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636"
/>
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
@Dosant @eokoneyo
[Chrome] Grid Layout by default (elastic#243181)
2437f40 
## Summary

close elastic#225263

This PR enables grid layout by default. This is supposed to be an
internal change with minimal user-experience changes.
See for more info elastic#225263
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
@Dosant @NicholasPeretti
[Chrome Grid] Revert the header displayed next to the sidenav (elasti…
93c3bb5 
…c#244628)

## Summary

One user-facing change we made with [the grid
layout](elastic#243181) is that we
started displaying the Kibana header next to the sidenav instead of
above it.

**Before grid layout**

<img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32"
src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2"
/>

**With grid layout** 

<img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24"
src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6"
/>


----- 

With this PR, we revert this user-facing change and return the header to
the top of the nav.


<img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38"
src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636"
/>
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
@Dosant @JordanSh
[Chrome Grid] Revert the header displayed next to the sidenav (elasti…
f1635a7 
…c#244628)

## Summary

One user-facing change we made with [the grid
layout](elastic#243181) is that we
started displaying the Kibana header next to the sidenav instead of
above it.

**Before grid layout**

<img width="630" height="409" alt="Screenshot 2025-10-31 at 11 22 32"
src="https://github.com/user-attachments/assets/f04eaf6a-9605-4346-b105-e172b5f990f2"
/>

**With grid layout** 

<img width="591" height="290" alt="Screenshot 2025-10-31 at 11 25 24"
src="https://github.com/user-attachments/assets/6e34f379-d979-4c82-a6fc-1c94811f17b6"
/>


----- 

With this PR, we revert this user-facing change and return the header to
the top of the nav.


<img width="1624" height="1056" alt="Screenshot 2025-11-28 at 12 54 38"
src="https://github.com/user-attachments/assets/b8bb6a56-4983-4341-9ae6-e52ac46b5636"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janmonschke janmonschke janmonschke approved these changes

@kapral18 kapral18 kapral18 approved these changes

@afharo afharo afharo approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@tomsonpl tomsonpl tomsonpl approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@kowalczyk-krzysztof kowalczyk-krzysztof kowalczyk-krzysztof approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino is a code owner automatically assigned from elastic/security-defend-workflows

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting chrome-grid Work related to Chrome refactor to grid layout ci:all-cypress-suites release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Workspace Chrome] Grid layout QA

10 participants

@Dosant @elasticmachine @janmonschke @kapral18 @afharo @ThomThomson @tomsonpl @MiriamAparicio @kowalczyk-krzysztof @kibanamachine